Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VCU118 Support to mp/pulp-v1-os-fpga Branch #362

Closed

Conversation

mrbilandi
Copy link

@mrbilandi mrbilandi commented Oct 4, 2024

This pull request integrates support for the Xilinx VCU118 FPGA platform into the mp/pulp-v1-os-fpga branch.

Changelog

Changes

cheshire/Makefile:

Modified to support any specified platform using BOARD=. For example, use "make ara-chs-xilinx BOARD=vcu118" to build for the VCU118 platform.

Checklist

  • Automated tests pass
  • Changelog updated
  • Code style guideline is observed

@mrbilandi mrbilandi requested a review from mp-17 as a code owner October 4, 2024 09:52
@aitesam961
Copy link

Nice work @mrbilandi were you able to run baremetal or OS on it?

Copy link
Collaborator

@mp-17 mp-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Once the questions are addressed, we can merge.

Makefile Outdated
CLANG_CC ?= clang
CLANG_CXX ?= clang++
CLANG_CC ?= clang-14
CLANG_CXX ?= clang++-14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop this change, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I’ll need to apply it on my end. I will bring it back in a new commit.

@mrbilandi
Copy link
Author

Hi @aitesam961
Yes, I was able to run. I think Matteo has plans to release the instructions.

@mrbilandi mrbilandi requested a review from mp-17 October 11, 2024 10:18
@mp-17
Copy link
Collaborator

mp-17 commented Oct 15, 2024

Hey @mrbilandi,

Since the base branch went out of sync due to flow modifications, I have pushed there your (adapted) commit and authored it with your username and email.

Everything is here in #319.

Let me know if this is okay for you and if I need to re-open this PR ;-)

@mp-17 mp-17 closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants